coopergillan commented on a change in pull request #9947:
URL: https://github.com/apache/airflow/pull/9947#discussion_r463732808
##########
File path: airflow/providers/jenkins/operators/jenkins_job_trigger.py
##########
@@ -110,7 +114,9 @@ def __init__(self,
self.jenkins_connection_id = jenkins_connection_id
self.max_try_before_job_appears = max_try_before_job_appears
- def build_job(self, jenkins_server):
+ def build_job(
+ self, jenkins_server: Jenkins, parameters: Optional[str] = "",
Review comment:
Making parameters a local variable here allow us to make the type
checking here easier. It also means we are no longer updating an attribute
outside of `__init__`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
