mik-laj commented on a change in pull request #9947:
URL: https://github.com/apache/airflow/pull/9947#discussion_r464014893



##########
File path: airflow/providers/jenkins/operators/jenkins_job_trigger.py
##########
@@ -235,3 +238,4 @@ def execute(self, context):
             # If we can we return the url of the job
             # for later use (like retrieving an artifact)
             return build_info['url']
+        return None

Review comment:
       This is mypa's expected behavior. If the function exits without calling 
`return`, Python implicitly returns None. Mypy requires us to be implicit in 
this case.
   
    > Explicit is better than implicit.
   
   https://www.python.org/dev/peps/pep-0020/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to