tanjinP opened a new pull request #10121: URL: https://github.com/apache/airflow/pull/10121
<!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- closes: #8286 ### Summary Will consider this a draft just to get a check if this is the right direction, also an opportunity to ask some clarifying questions: ### Questions + points that require clarity 1. created a new hook class with same name but added `Memcached` in it, is that okay? Also reusing the existing hook and operator modules (`cloud_memorystore.py`) 1. created a new how to guide because it didn't feel as natural to put in the Memcached specific operators in the existing one, does that make sense? 1. does it make sense to have a single `UpdateAndApply` operator that combines 2 REST API methods [specified here](https://cloud.google.com/memorystore/docs/memcached/reference/rest/v1beta2/projects.locations.instances#methods) - is that better as opposed to having them be independent operators? I would still have them be standalone methods in the Hook, the operator is what would call them one after another. ## What is next? After the initial review and clarification on approach, will: - continue to make the other operators reflecting [REST API methods](https://cloud.google.com/memorystore/docs/memcached/reference/rest/v1beta2/projects.locations.instances#methods), including Memcache specific ones like IAM and update and apply parameters. - this includes more tests - add examples to the DAG and corresponding entries in the How to guide - run all operators locally and test with personal GCP account that they all work as intended **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
