turbaszek commented on a change in pull request #9947:
URL: https://github.com/apache/airflow/pull/9947#discussion_r464466008
##########
File path: airflow/providers/jenkins/example_dags/example_jenkins_job_trigger.py
##########
@@ -44,7 +44,7 @@
job_trigger = JenkinsJobTriggerOperator(
task_id="trigger_job",
job_name="generate-merlin-config",
- parameters={"first_parameter": "a_value", "second_parameter": "18"},
+ parameters='{"first_parameter": "a_value", "second_parameter": "18"}',
Review comment:
> It seems like only the dictionary case is tested here. I'm thinking
there should be test coverage for each of these cases, right?
It would be nice to use parametrize to test each of possible type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
