coopergillan commented on a change in pull request #10164:
URL: https://github.com/apache/airflow/pull/10164#discussion_r465724280
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -104,11 +106,11 @@ class S3Hook(AwsBaseHook):
:class:`~airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook`
"""
- def __init__(self, *args, **kwargs):
- super().__init__(client_type='s3', *args, **kwargs)
+ def __init__(self, *args: str, **kwargs: str):
Review comment:
Looking at some other examples, it seems like you can only get the type
hinting to work if and when there are other arguments. Also kinda makes me
wonder if we need the `def __init__` at all or if we could just call the
`super` right away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
