turbaszek commented on a change in pull request #10084:
URL: https://github.com/apache/airflow/pull/10084#discussion_r466839460
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -36,6 +36,9 @@
import kubernetes.client.models as k8s
import yaml
from kubernetes.client.api_client import ApiClient
+from ..contrib.kubernetes.pod import (
Review comment:
Hm, I checked out this code in both cases `..` and `airflow.contrib` I
see warning `Access to a protected member _extract_volume_mounts of a module`.
So I don't think this is a problem. If there's any particular reason to have
such import I would be happy to have a comment on why we do this way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
