YingboWang commented on a change in pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#discussion_r467345925
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -71,15 +71,25 @@ def close(self):
def _render_filename(self, ti, try_number):
if self.filename_jinja_template:
- jinja_context = ti.get_template_context()
- jinja_context['try_number'] = try_number
+ if hasattr(ti, 'task'):
+ jinja_context = ti.get_template_context()
+ jinja_context['try_number'] = try_number
+ else:
+ jinja_context = {
+ 'ti': ti,
+ 'ts': ti.execution_date.isoformat(),
+ 'try_number': try_number,
+ }
return self.filename_jinja_template.render(**jinja_context)
return self.filename_template.format(dag_id=ti.dag_id,
task_id=ti.task_id,
execution_date=ti.execution_date.isoformat(),
try_number=try_number)
+ def _read_grouped_logs(self):
+ return False
Review comment:
For es_task_handler it will return True.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
