potiuk commented on pull request #279:
URL: https://github.com/apache/airflow-site/pull/279#issuecomment-671048559


   Looks great!
   
   > Resolves 
[apache/airflow#10196](https://github.com/apache/airflow/issues/10196)
   > 
   > @potiuk I have the following questions.
   > 
   > 1. Nov 21, 2019
   >    I've tried to link all contributors' github profile wherever mentioned. 
But I couldn't find the profile Id for Kevin Yang.
   See below :)
   
   > 2. Oct 18, 2019
   >    Same update as Nov 22, 2019. Should I remove one of them?
   
   Yep. mistake. Remove the Nov 22nd one.
   
   > 3. May 2, 2019
   >    Need profile Id for Bas Harenslak, Joshua Carp, Kevin Yang. Similar to 
question no. 1.
   
   1) 3)  Missing profiles: @KevinYang21 @BasPH @jmcarp 
   
   > 4. April 22, 2016
   >    Migrating to Apache Phrase points to announcements confluence page. 
Should we repoint this to the website?
   
   Yes please!
   
   Few  comments:
   1) It would be great to add some whitespace at the top of the Announcement 
page (as it is for other pages). Currently the header covers half of the first 
line:
   
   ![Screenshot from 2020-08-09 
14-51-55](https://user-images.githubusercontent.com/595491/89732555-e6f04900-da4f-11ea-8be5-e83759c6144e.png)
   
   2) The list of the backport providers also has far too much space in. Maybe 
better to have them as bullets rather than numbered list to squeeze them 
together.
   
   ![Screenshot from 2020-08-09 
14-52-42](https://user-images.githubusercontent.com/595491/89732581-fec7cd00-da4f-11ea-9954-a750b08d6cf0.png)
   
   BTW.  I am not sure if you realize that but you can easily preview the 
generated pages now. It is enough to download the artifact from the PR, extract 
it and run `python -m http.server` and you will be able to preview it at 
http://localhost:8000
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to