aneesh-joseph opened a new issue #10278:
URL: https://github.com/apache/airflow/issues/10278
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the
following questions.
Don't worry if they're not all applicable; just try to include what you can
:-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
This questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: 1.10.10
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release):
- **Kernel** (e.g. `uname -a`):
- **Install tools**:
- **Others**:
**What happened**:
Airflow makes way too many API requests in case of invalid executor_config
or mutation hook
<!-- (please include exact error messages if you can) -->
**What you expected to happen**:
Airflow fails fast
<!-- What do you think went wrong? -->
**How to reproduce it**:
Update your pod mutation hook or executor_config such that it results in an
invalid Pod request to the k8s API. Example use an executor_config like
```
executor_config = {
"KubernetesExecutor": {
"volumes": [
{
"name": "correct_name",
"emptyDir": {}
}
],
"volume_mounts": [
{
"name": "incorrect_name",
"mountPath": "/opt/airflow/mount"
}
]
}
}
```
Airflow ill prepare a Pod request and send it to the k8s API, which will
respond back suggesting that the Pod request is invalid,
```
[2020-08-10 15:42:16,631] {rest.py:228} DEBUG - response body:
{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Pod
\"newdagtesttask1-92fff529de5b42cdbb153cc7bbfade9c\" is invalid:
spec.containers[0].volumeMounts[3].name: Not found:
\"incorrect_name\"","reason":"Invalid","details":{"name":"newdagtesttask1-92fff529de5b42cdbb153cc7bbfade9c","kind":"Pod","causes":[{"reason":"FieldValueNotFound","message":"Not
found:
\"incorrect_name\"","field":"spec.containers[0].volumeMounts[3].name"}]},"code":422}
HTTP response body:
{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Pod
\"newdagtesttask1-92fff529de5b42cdbb153cc7bbfade9c\" is invalid:
spec.containers[0].volumeMounts[3].name: Not found:
\"incorrect_name\"","reason":"Invalid","details":{"name":"newdagtesttask1-92fff529de5b42cdbb153cc7bbfade9c","kind":"Pod","causes":[{"reason":"FieldValueNotFound","message":"Not
found:
\"incorrect_name\"","field":"spec.containers[0].volumeMounts[3].name"}]},"code":422}
```
but Airflow will keep retrying the same request. I counted till 250 in
couple of minutes and then deleted my test deployment :) It would be great if
Airflow fails fast in such cases where the k8s API response suggests that the
request is invalid
<!---
As minimally and precisely as possible. Keep in mind we do not have access
to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using
minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a
youtube video of the bug in action
You can include images using the .md style of
To record a screencast, mac users can use QuickTime and then create an
unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**:
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
