dstandish commented on a change in pull request #9677: URL: https://github.com/apache/airflow/pull/9677#discussion_r468235221
########## File path: airflow/providers/microsoft/azure/transfers/sftp_to_wasb.py ########## @@ -0,0 +1,166 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +This module contains SFTP to Azure Blob Storage operator. +""" +import os +from tempfile import NamedTemporaryFile +from typing import Any, Dict, List, Optional, Tuple + +from airflow.exceptions import AirflowException +from airflow.models import BaseOperator +from airflow.providers.microsoft.azure.hooks.wasb import WasbHook +from airflow.providers.sftp.hooks.sftp import SFTPHook +from airflow.utils.decorators import apply_defaults + +WILDCARD = "*" +SFTP_FILE_PATH = "SFTP_FILE_PATH" +BLOB_NAME = "BLOB_NAME" + + +class SFTPToWasbOperator(BaseOperator): Review comment: initally when I made the comment i had forgotten that dry_run is not abstract... but still i stand by the suggestion, because you can override it and extend the behavior adding the more useful functionality here and still super().dry_run() to preserve preserve the built-in functionality of just printing to logs the templated fields ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
