[
https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178752#comment-17178752
]
ASF GitHub Bot commented on AIRFLOW-6786:
-----------------------------------------
potiuk commented on pull request #7407:
URL: https://github.com/apache/airflow/pull/7407#issuecomment-674689914
Hey @dferguson992 - sad to see this is difficult. Unfortunately, we have
quite some expectations when it comes to code contributions. We keep on
discussing it, how big of an obstacle it is for new contributors, but as a
community, we need to make sure that we can take over the code and maintain it
further when it gets contributed. This often means documentation and code
linting, and following the same practices for all parts of the code. So
apologies if it's a bit involved - it is so for a reason.
We are happy to help if you would like to learn how to do it. It's OK if
takes weeks or months to contribute even small change, so if you have just a
little time to spare a week, it can be done in baby steps. We understand the
whole process can be a little overwhelming, but if you approach it one thing at
a time this might work. And we encourage you to do so - the Kafka hooks/sensors
seem to be a really cool addition.
I am happy to provide some guidance. I think what is really important to
start with is that you learn how to rebase your changes on top of master. You
will have to do it as the first thing every time you come back to working on
this, and it's easier than you think. We have some helpful guide on it here:
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#how-to-rebase-pr.
And making sure the documentation is updated after the rebase, might be the
first thing that you can fix without much of learning I think. Maybe start with
that and let's do it together one thing at a time? What do you think?
Feel free to reach out here or in slack if you need some help. I hope we can
make it together :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor
> ------------------------------------------------------------
>
> Key: AIRFLOW-6786
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6786
> Project: Apache Airflow
> Issue Type: New Feature
> Components: contrib, hooks
> Affects Versions: 1.10.9
> Reporter: Daniel Ferguson
> Assignee: Daniel Ferguson
> Priority: Minor
>
> Add the KafkaProducerHook.
> Add the KafkaConsumerHook.
> Add the KafkaSensor which listens to messages with a specific topic.
> Related Issue:
> #1311 (Pre-dates Jira Migration)
> Reminder to contributors:
> You must add an Apache License header to all new files
> Please squash your commits when possible and follow the 7 rules of good Git
> commits
> I am new to the community, I am not sure the files are at the right place or
> missing anything.
> The sensor could be used as the first node of a dag where the second node can
> be a TriggerDagRunOperator. The messages are polled in a batch and the dag
> runs are dynamically generated.
> Thanks!
> Note, as per denied PR [#1415|https://github.com/apache/airflow/pull/1415],
> it is important to mention these integrations are not suitable for
> low-latency/high-throughput/streaming. For reference, [#1415
> (comment)|https://github.com/apache/airflow/pull/1415#issuecomment-484429806].
> Co-authored-by: Dan Ferguson
> [[email protected]|mailto:[email protected]]
> Co-authored-by: YuanfΞi Zhu
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
