mik-laj commented on a change in pull request #10023:
URL: https://github.com/apache/airflow/pull/10023#discussion_r471719367
##########
File path: airflow/providers/cncf/kubernetes/sensors/spark_kubernetes.py
##########
@@ -37,38 +39,75 @@ class SparkKubernetesSensor(BaseSensorOperator):
:type namespace: str
:param kubernetes_conn_id: the connection to Kubernetes cluster
:type kubernetes_conn_id: str
+ :param attach_log: determines whether logs for driver pod should be
appended to the sensor log
+ :type attach_log: bool
"""
- template_fields = ('application_name', 'namespace')
- FAILURE_STATES = ('FAILED', 'UNKNOWN')
- SUCCESS_STATES = ('COMPLETED',)
+ template_fields = ("application_name", "namespace")
+ FAILURE_STATES = ("FAILED", "UNKNOWN")
+ SUCCESS_STATES = ("COMPLETED",)
@apply_defaults
- def __init__(self, *,
- application_name: str,
- namespace: Optional[str] = None,
- kubernetes_conn_id: str = 'kubernetes_default',
- **kwargs):
+ def __init__(
+ self,
+ application_name: str,
Review comment:
```suggestion
self,
*,
application_name: str,
```
See: https://github.com/apache/airflow/issues/9942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
