yuqian90 commented on a change in pull request #10153:
URL: https://github.com/apache/airflow/pull/10153#discussion_r472097920
##########
File path: airflow/models/baseoperator.py
##########
@@ -380,7 +387,15 @@ def __init__(
stacklevel=3
)
validate_key(task_id)
- self.task_id = task_id
+ self._task_id = task_id
Review comment:
You are right. i'm reverting this back to `self.task_id`.
That said, I don't think we should allow people to change `task_id` of a
task once it's set. That causes the task_dict to have a wrong key and will
certainly cause bugs. So maybe it's better to have `task_id` as a readonly
propertly. That is out of the scope of this PR. So i'll leave things in the
original state for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
