Craig-Chatfield opened a new pull request #10373:
URL: https://github.com/apache/airflow/pull/10373


   ### Bug Fix
   
   Currently `py_requirements` defaults to an empty list in the Dataflow 
operator if no value is passed into the function call. As such the check in the 
hook would always evaluate to True - running the Dataflow commands inside a 
virtualenv.
   
   This PR corrects the evaluation behaviour of the `if` statement so that an 
empty list will evaluate as `false`.
   
   ### UnitTests
   
   As part of this PR two unit tests have been introduced, for testing the 
calls with an empty/non-empty `py_requirements`.
   
   closes: #ISSUE
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to