yesemsanthoshkumar commented on pull request #10343: URL: https://github.com/apache/airflow/pull/10343#issuecomment-675516198
@mik-laj > 2. I'm directing the link to the cluster if the job hasn't run and not generated any JobId. Is this approach valid? Do you want me to change this behaviour? The link is not being redirected to the cluster URL if there is no detail of the job in the system. > 3. I coudn't find the cluster_name argument in [DataprocSubmitJobOperator](https://airflow.readthedocs.io/en/latest/_api/airflow/providers/google/cloud/operators/dataproc/index.html#airflow.providers.google.cloud.operators.dataproc.DataprocSubmitJobOperator) for which I've added the links. Shoud I add the links to [DataprocJobBaseOperator](https://airflow.readthedocs.io/en/latest/_api/airflow/providers/google/cloud/operators/dataproc/index.html#airflow.providers.google.cloud.operators.dataproc.DataprocJobBaseOperator)? Or Should I add on both? Implemented on both the operators. For subclasses of DataprocJobBaseOperators, I've added tests only for DataprocSubmitSparkJob operator as the other operators are anyway deprecated. Please have a look at the above comments by @turbaszek regarding this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
