mik-laj commented on a change in pull request #10377:
URL: https://github.com/apache/airflow/pull/10377#discussion_r472582617
##########
File path: docs/build_docs.py
##########
@@ -15,8 +15,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
Review comment:
> For example if you'd do it after adding spellchecking it would have
failed and you would have to figure out that you have to re-rerun 'pip install
.[doc]' again. For people who are casual contributors and do it very rarely
this might come as a surprise. Also they might not remember that they have a
separate virtualenv where they should build the docs and they would loose time
trying to find out what's going on. They also might have an even older version
of the virtualenv that will not work well.
This is an issue that occurs with every Python project, so I don't see a big
problem here. If you are missing the library, you have to reinstall the
dependencies. On other hand, building documentation without Docker is faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
