potiuk commented on a change in pull request #10390:
URL: https://github.com/apache/airflow/pull/10390#discussion_r472800865
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -559,12 +558,27 @@ function build_ci_image() {
echo >&2
exit 1
fi
+ if [[ -n ${SPIN_PID:=""} ]]; then
+ kill -HUP "${SPIN_PID}" || true
+ wait "${SPIN_PID}" || true
+ echo > "${DETECTED_TERMINAL}"
Review comment:
The whole thing is about trying to print progress to most likely
terminal i fbuild happens insde pre-commit inside `git commit command - it
won't always succeed but in vast majority of cases of developer workstation -
it will
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
