potiuk commented on a change in pull request #10441:
URL: https://github.com/apache/airflow/pull/10441#discussion_r475568174
##########
File path: scripts/in_container/run_docs_build.sh
##########
@@ -28,7 +28,7 @@ sudo rm -rf "${AIRFLOW_SOURCES}/docs/_api/*"
sudo -E "${AIRFLOW_SOURCES}/docs/build_docs.py" "${@}"
-if [[ ${GITHUB_ACTIONS} == "true" && -d "${AIRFLOW_SOURCES}/docs/_build/html"
]]; then
+if [[ ${GITHUB_ACTIONS:="false"} == "true" && -d
"${AIRFLOW_SOURCES}/docs/_build/html" ]]; then
rm -rf "/files/documentation"
cp -r "${AIRFLOW_SOURCES}/docs/_build/html" "/files/documentation"
Review comment:
Is it really that important that you need a note about it? The whole
point about having "/files" and that they are used for transferring the files
is described already in the #10380.
https://github.com/PolideaInternal/airflow/blob/future-ci-documentation/CI.rst#ci-environment
(see MOUNT_FILES) parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
