potiuk commented on a change in pull request #10559:
URL: https://github.com/apache/airflow/pull/10559#discussion_r477266121
##########
File path: airflow/models/connection.py
##########
@@ -380,3 +381,17 @@ def extra_dejson(self) -> Dict:
self.log.error("Failed parsing the json for conn_id %s",
self.conn_id)
return obj
+
+ @classmethod
+ def get_connections_from_secrets(cls, conn_id: str) -> List['Connection']:
Review comment:
Unfottunately It won't work - at this time "Connection" is not yet
defined and mypy will complain (because it is inside the Connection definition
- quoting is specifically foreseen for that case
https://www.python.org/dev/peps/pep-0484/#forward-references
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
