[
https://issues.apache.org/jira/browse/AIRFLOW-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187985#comment-17187985
]
ASF GitHub Bot commented on AIRFLOW-1424:
-----------------------------------------
alexbegg commented on pull request #2460:
URL: https://github.com/apache/airflow/pull/2460#issuecomment-684010238
@ultrabug Going over this whole thread, I want some clarification before I
step in to development for this:
1. Will this show the next execution date for a DAG which has a future
`start_date`, or the DAG has not ran? From a look of the code it seems it would
fail to show the `next_run_date` if the date is in the future due to this check
which would return None _before_ the `dry_run` returns the `next_run_date`
(this is a snippet from current master as this PR is a bit behind):
https://github.com/apache/airflow/blob/515cc72c995429c8c007f853ade385d79fcbac90/airflow/jobs/scheduler_job.py#L648-L650
maybe wrap that in parentheses add `and not dry_run` to that line?
2. Is the intention to still use the `dry_run` functionality to return the
next expected execution date?
3. I assume it makes no sense to show the next execution date if the DAG is
paused? Or am I mistaken?
Also, regarding putting this in the "Last Run" column, if it should be
showing the next execution date if the DAG has not run then I think the "Last
Run" column might not be the best place to put this in a tooltip because the
column currently is empty, maybe it should go in the "Schedule" column as
discussed way back when this PR started?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make the next execution date of DAGs visible
> --------------------------------------------
>
> Key: AIRFLOW-1424
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1424
> Project: Apache Airflow
> Issue Type: New Feature
> Components: DAG
> Reporter: Ultrabug
> Priority: Major
>
> The scheduler's DAG run creation logic can be tricky and one is
> easily confused with the start_date + interval
> and period end scheduling way of thinking.
> It would ease airflow's usage to add a next execution field to DAGs
> so that we can very easily see the (un)famous period end after which
> the scheduler will create a new DAG run for our workflows.
> These patches are a simple way to implement this on the DAG model
> and make use of this in the interface.
> Screenshots are on the github PR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
