alexbegg edited a comment on pull request #2460: URL: https://github.com/apache/airflow/pull/2460#issuecomment-684010238
@ultrabug Going over this whole thread, I want some clarification before I dive deeper into development this: 1. Will this show the next execution date for a DAG which has a future `start_date`, or the DAG has not ran? From a look of the code it seems it would fail to show the `next_run_date` if the date is in the future due to this check which would return None _before_ the `dry_run` returns the `next_run_date` (this is a snippet from current master as this PR is a bit behind): https://github.com/apache/airflow/blob/515cc72c995429c8c007f853ade385d79fcbac90/airflow/jobs/scheduler_job.py#L648-L650 maybe wrap that in parentheses add `and not dry_run` to that line? 2. Is the intention to still use the `dry_run` functionality to return the next expected execution date? 3. I assume it makes no sense to show the next execution date if the DAG is paused? Or am I mistaken? Also, regarding putting this in the "Last Run" column, if it should be showing the next execution date if the DAG has not run then I think the "Last Run" column might not be the best place to put this in a tooltip because the column currently is empty, maybe it should go in the "Schedule" column as discussed way back when this PR started? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
