houqp commented on pull request #10351:
URL: https://github.com/apache/airflow/pull/10351#issuecomment-684552078
based on the diff, it does seem to cause openapi-generator to generate less
sensible code:
```diff
diff -u ./clients/go_target_branch/airflow/model_dag_run.go
./clients/go/airflow/model_dag_run.go
--- ./clients/go_target_branch/airflow/model_dag_run.go 2020-08-29
20:35:34.312964227 +0000
+++ ./clients/go/airflow/model_dag_run.go 2020-08-29 20:35:30.524903466
+0000
@@ -22,7 +22,7 @@
// The start time. The time when DAG run was actually created.
StartDate time.Time `json:"start_date,omitempty"`
EndDate *time.Time `json:"end_date,omitempty"`
- State DagState `json:"state,omitempty"`
+ State OneOfDagState `json:"state,omitempty"`
ExternalTrigger bool `json:"external_trigger,omitempty"`
// JSON object describing additional configuration parameters. The
value of this field can be set only when creating the object. If you try to
modify the field of an existing object, the request fails with an BAD_REQUEST
error.
Conf map[string]interface{} `json:"conf,omitempty"`
diff -u ./clients/go_target_branch/airflow/model_task.go
./clients/go/airflow/model_task.go
--- ./clients/go_target_branch/airflow/model_task.go 2020-08-29
20:35:34.476966679 +0000
+++ ./clients/go/airflow/model_task.go 2020-08-29 20:35:30.668906920
+0000
@@ -27,8 +27,8 @@
Queue string `json:"queue,omitempty"`
Pool string `json:"pool,omitempty"`
PoolSlots float32 `json:"pool_slots,omitempty"`
- ExecutionTimeout TimeDelta `json:"execution_timeout,omitempty"`
- RetryDelay TimeDelta `json:"retry_delay,omitempty"`
+ ExecutionTimeout OneOfnullTimeDelta `json:"execution_timeout,omitempty"`
+ RetryDelay OneOfnullTimeDelta `json:"retry_delay,omitempty"`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
