houqp commented on a change in pull request #5:
URL: https://github.com/apache/airflow-client-go/pull/5#discussion_r481719209
##########
File path: .github/workflows/ci.yml
##########
@@ -46,8 +46,10 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v1
with:
- go-version: 1.14
+ go-version: 1.15
id: go
- name: build & test
- run: cd airflow && go test
+ run: |
+ go test
+ cd airflow && go test
Review comment:
i also don't have a strong opinion here. i usually use makefile for my
own projects, but since Jarek has a strong opinion on this let's just not use
it for now. I am also very hesitate to use heavy tools like bazel for simple
tasks like this. i am going to leave it as is for now since it's just invoking
simple `go test` command. But if any one of you have ideas on how we should
further automate this, i am more than happy to update my PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
