mik-laj commented on a change in pull request #10594:
URL: https://github.com/apache/airflow/pull/10594#discussion_r482787734
##########
File path: airflow/api_connexion/endpoints/version_endpoint.py
##########
@@ -32,6 +33,7 @@ class VersionInfo(NamedTuple):
git_version: Optional[str]
[email protected]_access([("can_read", "Version")])
def get_version():
Review comment:
This will allow the client's behavior to be changed before authorization
is performed. I am able to imagine that other authorization methods may be
required depending on the version.
Kubernetes API don't have aaccesss control on /version endpoint
```
$ ENDPOINT=$(gcloud container clusters describe airflow-cluster --zone
us-central1 --format='value(endpoint)')
$ curl --insecure https://$ENDPOINT/version
{
"major": "1",
"minor": "16+",
"gitVersion": "v1.16.13-gke.1",
"gitCommit": "688c6543aa4b285355723f100302d80431e411cc",
"gitTreeState": "clean",
"buildDate": "2020-07-21T02:37:26Z",
"goVersion": "go1.13.9b4",
"compiler": "gc",
"platform": "linux/amd64"
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
