mik-laj commented on a change in pull request #10453:
URL: https://github.com/apache/airflow/pull/10453#discussion_r483307212
##########
File path: airflow/providers/cncf/kubernetes/hooks/kubernetes.py
##########
@@ -36,32 +36,52 @@ class KubernetesHook(BaseHook):
"""
Creates Kubernetes API connection.
+ - use in cluster configuration by using `extra__kubernetes__in_cluster` in
connection
+ - use custom configuration either by providing content of kubeconfig file
via
+ `extra__kubernetes__kube_config` in connection
+ - use custom config by provideing path to the file using
`extra__kubernetes__kube_config_path`
+ - use default config by providing no extras
Review comment:
```suggestion
- use in cluster configuration by using `extra__kubernetes__in_cluster`
in connection
- use custom configuration either by providing content of kubeconfig
file via
`extra__kubernetes__kube_config` in connection
- use custom config by provideing path to the file using
`extra__kubernetes__kube_config_path`
- use default config by providing no extras
```
Can you update the guide also and add cross-reference between the hook and
guide?
https://airflow.readthedocs.io/en/latest/howto/connection/kubernetes.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
