jedcunningham commented on pull request #10719:
URL: https://github.com/apache/airflow/pull/10719#issuecomment-687819060


   Thanks for taking a look @XD-DENG.
   
   Long story short, I just changed all the extra link tests to run with a 
Viewer instead of an Admin user.
   
   `TestBase.login` only supports an Admin user: 
https://github.com/apache/airflow/blob/master/tests/www/test_views.py#L134
   
   So I took inspiration from `TestDagACLView.login`: 
https://github.com/apache/airflow/blob/master/tests/www/test_views.py#L1679
   
   `TestBase.login` probably needs more flexibility/features (probably take 
`TestDagACLView.login` and generalize it a bit), but I didn't want to introduce 
that much change in the test suite for a single permission change 🤷‍♂️.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to