rootcss opened a new issue #10776:
URL: https://github.com/apache/airflow/issues/10776


   In the serve_logs code 
[here](https://github.com/apache/airflow/blob/master/airflow/utils/serve_logs.py),
 are we intentionally starting the flask server in dev mode 
(`flask_app.run()`)? @mik-laj 
   
   ```python
   def serve_logs():
       """Serves logs generated by Worker"""
       print("Starting flask")
       flask_app = flask.Flask(__name__)
   
       @flask_app.route('/log/<path:filename>')
       def serve_logs_view(filename):  # pylint: disable=unused-variable
           log_directory = os.path.expanduser(conf.get('logging', 
'BASE_LOG_FOLDER'))
           return flask.send_from_directory(
               log_directory,
               filename,
               mimetype="application/json",
               as_attachment=False)
   
       worker_log_server_port = conf.getint('celery', 'WORKER_LOG_SERVER_PORT')
       flask_app.run(host='0.0.0.0', port=worker_log_server_port)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to