eladkal commented on pull request #10760: URL: https://github.com/apache/airflow/pull/10760#issuecomment-688179394
> In terms of adding other parameters, do you think that adding parameters related to file creation like approx_max_file_size_bytes and field_delimiter to happen within write_object_to_file would make sense? Alternatively the execute method would chunk the results and call write_object_to_file multiple times. Ignore my previous comment I would say that providing the same GCP parameters like `FacebookAdsReportToGcsOperator` is OK though I'm not sure why it doesn't have `delegate_to`. Could be that at some point there will be a BaseFileToGcsOperator which will prevent the need from adding `delegate_to` & `impersonation_chain` to every operator. I think @mik-laj or @turbaszek are better to answer what parameters are mandatory for GCP. I'll review the salesforce part later this week. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
