kaxil commented on a change in pull request #10756:
URL: https://github.com/apache/airflow/pull/10756#discussion_r484519932
##########
File path: airflow/kubernetes/pod_generator_deprecated.py
##########
@@ -0,0 +1,652 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Do we really need a separate file here? We just want to deprecate but
still support `KubernetesExecutor` config. The code you delete in
`airflow/kubernetes/pod_generator.py` can just go in a separate function or a
static method (or just in that if block) in the same file, just prefix it with
`_`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
