jedcunningham commented on a change in pull request #10663:
URL: https://github.com/apache/airflow/pull/10663#discussion_r485198197
##########
File path: airflow/models/dagbag.py
##########
@@ -269,7 +270,12 @@ def _load_modules_from_file(self, filepath, safe_mode):
return [new_module]
except Exception as e: # pylint: disable=broad-except
self.log.exception("Failed to import: %s", filepath)
- self.import_errors[filepath] = str(e)
+ if conf.getboolean('webserver',
'dagbag_import_error_tracebacks'):
Review comment:
Yeah, looking with fresh eyes, `core` is a much better fit.
Think we should also set attributes like we do for `DAGBAG_IMPORT_TIMEOUT`
so we only hit the config system once?
e.g.
https://github.com/apache/airflow/blob/master/airflow/models/dagbag.py#L80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
