millertracy edited a comment on pull request #10591: URL: https://github.com/apache/airflow/pull/10591#issuecomment-689725958
> Hey @millertracy -> reviewed it. Nice piece of provider :). > > The main comment is about the settup.py change (plexus needs 'plexus' extra and arrow should be added there - also then plexus extra should be added to "all_devs/all" extras similarly to other extras. > > Also then you will need to mark it as "provider" dependency in PROVIDERS_REQUIREMENTS. > > This should likely fix backport package problem that you have (airflow 1.10.10 does not have arrow as requirement, neither the generated backport package). > > There is also some work to make the docs work - some spellcheck problems from what I see. > > One more NIT - It would also be great if you create a HowTo out of your example. You can see how other operators do that, but basically it is a very short "Howto" doc that extracts part of the "example_dag" and adds some description on what the operator does. > > Another part (but this is something that we have no full CI automation yet) is to turn the example dag into a runnable "system test". This is described in https://github.com/apache/airflow/blob/master/TESTING.rst#airflow-system-tests - and it's not required, but it seems to be easy to do in your case as this is rather simple example you have. > > We plan to automate system tests later this year and it would be great to have such easy-to-run system test in place. But this one is nice-to-havee. > > This is actually the most powerful part of the exmple_dags @potiuk thank you! I will make those changes. will i also need to add backward compatibility for airflow 1.10* by adding plexus hook/operator to the airflow.contrib package? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
