tszerszen commented on a change in pull request #10847:
URL: https://github.com/apache/airflow/pull/10847#discussion_r486108435
##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -1808,6 +1808,8 @@ def __init__(
gcp_conn_id: str = "google_cloud_default",
impersonation_chain: Optional[Union[str, Sequence[str]]] = None,
asynchronous: bool = False,
+ hook: Optional[DataprocHook] = None,
+ job_id: str = '',
Review comment:
@michalslowikowski00 > I think we always use such notation.
I think such change will raise `SyntaxError: non-default argument follows
default argument`, since `job_id` is optional.
What about the following notation?
```
job_id: Optional[str] = None,
```
But I got mypy error with the above, becouse `job_id` might be `None` when
method `cancel_job` on `hook` is called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
