dimberman commented on a change in pull request #10393:
URL: https://github.com/apache/airflow/pull/10393#discussion_r486513263
##########
File path: chart/values.yaml
##########
@@ -541,32 +543,11 @@ config:
namespace: '{{ .Release.Namespace }}'
airflow_configmap: '{{ include "airflow_config" . }}'
airflow_local_settings_configmap: '{{ include "airflow_config" . }}'
+ pod_template_file: '{{ include "airflow_pod_template_file" . }}/{{
.Values.podTemplateFile }}'
worker_container_repository: '{{ .Values.images.airflow.repository |
default .Values.defaultAirflowRepository }}'
worker_container_tag: '{{ .Values.images.airflow.tag | default
.Values.defaultAirflowTag }}'
worker_container_image_pull_policy: '{{ .Values.images.airflow.pullPolicy
}}'
- worker_service_account_name: '{{ .Release.Name }}-worker-serviceaccount'
- image_pull_secrets: '{{ template "registry_secret" . }}'
- dags_in_image: '{{ ternary "False" "True" (or .Values.dags.gitSync.enabled
.Values.dags.persistence.enabled) }}'
delete_worker_pods: 'True'
- run_as_user: '{{ .Values.uid }}'
- fs_group: '{{ .Values.gid }}'
- git_dags_folder_mount_point: '{{- if or .Values.dags.gitSync.enabled
.Values.dags.persistence.enabled }}{{ include "airflow_dags_mount_path" .
}}{{end}}'
- dags_volume_mount_point: '{{- if or .Values.dags.gitSync.enabled
.Values.dags.persistence.enabled }}{{ include "airflow_dags_mount_path" . }}{{
end }}'
- dags_volume_claim: '{{- if .Values.dags.persistence.enabled }}{{ include
"airflow_dags_volume_claim" . }}{{ end }}'
- dags_volume_subpath: '{{- if .Values.dags.persistence.enabled
}}{{.Values.dags.gitSync.dest }}/{{ .Values.dags.gitSync.subPath }}{{ end }}'
- git_repo: '{{- if and .Values.dags.gitSync.enabled (not
.Values.dags.persistence.enabled) }}{{ .Values.dags.gitSync.repo }}{{ end }}'
- git_branch: '{{ .Values.dags.gitSync.branch }}'
- git_sync_rev: '{{ .Values.dags.gitSync.rev }}'
- git_sync_depth: '{{ .Values.dags.gitSync.depth }}'
- git_sync_root: '{{ .Values.dags.gitSync.root }}'
- git_sync_dest: '{{ .Values.dags.gitSync.dest }}'
- git_sync_container_repository: '{{
.Values.dags.gitSync.containerRepository }}'
- git_sync_container_tag: '{{ .Values.dags.gitSync.containerTag }}'
- git_sync_init_container_name: '{{ .Values.dags.gitSync.containerName }}'
- git_sync_run_as_user: '{{ .Values.uid }}'
- git_ssh_known_hosts_configmap_name: '{{- if
.Values.dags.gitSync.knownHosts }}{{ include "airflow_config" . }}{{ end }}'
- git_ssh_key_secret_name: '{{- if .Values.dags.gitSync.sshKeySecret }}{{
.Values.dags.gitSync.sshKeySecret }}{{ end }}'
- git_sync_credentials_secret: '{{- if
.Values.dags.gitSync.credentialsSecret }}{{
.Values.dags.gitSync.credentialsSecret }}{{ end }}'
Review comment:
@ashb every value in this section is brought from other parts of the
helm file. Should we keep this around or delete this section and still have a
default pod_template file from those other values (seeing as this section is
specifically made for the airflow.cfg)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
