ashb commented on a change in pull request #10872:
URL: https://github.com/apache/airflow/pull/10872#discussion_r487082094
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
