ashb commented on a change in pull request #10872:
URL: https://github.com/apache/airflow/pull/10872#discussion_r487082094
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
##########
File path: chart/templates/configmap.yaml
##########
@@ -55,3 +55,11 @@ data:
known_hosts: |
{{ .Values.dags.gitSync.knownHosts | nindent 4 }}
{{- end }}
+{{- if eq .Values.executor "KubernetesExecutor" }}
+ pod_template_file.yaml: |-
+{{- if .Values.podTemplateFile }}
Review comment:
This value name needs clarifying -- seeing the name `file` I'd expect
this to be a path to the file, but if I'm reading this correctly the helm value
is the contents of the file/YAML to use as the pod template, correct?
If so `.Values.podTemplate` or `.Values.executorPodTemplate` might be a
better name
##########
File path: chart/values.yaml
##########
@@ -27,6 +27,8 @@ gid: 50000
# Used for mount paths
airflowHome: "/opt/airflow"
+podTemplateFilePath: ~
Review comment:
This one isn't used anywhere.
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Is it not possible to have this in the "normal" airflow `chart/` and
have this as `files/pod-template-file.yaml`?
##########
File path: chart_pod_template_file/tests/pod-template-file_test.yaml
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+templates:
+ - pod-template-file.yaml
Review comment:
Nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
