turbaszek commented on a change in pull request #10869:
URL: https://github.com/apache/airflow/pull/10869#discussion_r486816384
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -300,7 +300,7 @@ def __init__( # pylint: disable=too-many-arguments
self.model_id = model_id
self.location = location
self.project_id = project_id
- self.params = params # type: ignore
+ self.prediction_params = prediction_params # type: ignore
Review comment:
```suggestion
self.prediction_params = prediction_params
```
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -240,9 +240,9 @@ class AutoMLBatchPredictOperator(BaseOperator):
written. If a dict is provided, it must be of the same form as the
protobuf message
`google.cloud.automl_v1beta1.types.BatchPredictOutputConfig`
:type output_config: Union[dict,
~google.cloud.automl_v1beta1.types.BatchPredictOutputConfig]
- :param params: Additional domain-specific parameters for the predictions,
any string must be up to
+ :param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
Review comment:
```suggestion
:param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
```
This line is too long
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -300,7 +300,7 @@ def __init__( # pylint: disable=too-many-arguments
self.model_id = model_id
self.location = location
self.project_id = project_id
- self.params = params # type: ignore
+ self.prediction_params = prediction_params # type: ignore
Review comment:
```suggestion
self.prediction_params = prediction_params
```
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -240,9 +240,9 @@ class AutoMLBatchPredictOperator(BaseOperator):
written. If a dict is provided, it must be of the same form as the
protobuf message
`google.cloud.automl_v1beta1.types.BatchPredictOutputConfig`
:type output_config: Union[dict,
~google.cloud.automl_v1beta1.types.BatchPredictOutputConfig]
- :param params: Additional domain-specific parameters for the predictions,
any string must be up to
+ :param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
Review comment:
```suggestion
:param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
```
This line is too long
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -300,7 +300,7 @@ def __init__( # pylint: disable=too-many-arguments
self.model_id = model_id
self.location = location
self.project_id = project_id
- self.params = params # type: ignore
+ self.prediction_params = prediction_params # type: ignore
Review comment:
```suggestion
self.prediction_params = prediction_params
```
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -240,9 +240,9 @@ class AutoMLBatchPredictOperator(BaseOperator):
written. If a dict is provided, it must be of the same form as the
protobuf message
`google.cloud.automl_v1beta1.types.BatchPredictOutputConfig`
:type output_config: Union[dict,
~google.cloud.automl_v1beta1.types.BatchPredictOutputConfig]
- :param params: Additional domain-specific parameters for the predictions,
any string must be up to
+ :param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
Review comment:
```suggestion
:param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
```
This line is too long
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -300,7 +300,7 @@ def __init__( # pylint: disable=too-many-arguments
self.model_id = model_id
self.location = location
self.project_id = project_id
- self.params = params # type: ignore
+ self.prediction_params = prediction_params # type: ignore
Review comment:
```suggestion
self.prediction_params = prediction_params
```
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -240,9 +240,9 @@ class AutoMLBatchPredictOperator(BaseOperator):
written. If a dict is provided, it must be of the same form as the
protobuf message
`google.cloud.automl_v1beta1.types.BatchPredictOutputConfig`
:type output_config: Union[dict,
~google.cloud.automl_v1beta1.types.BatchPredictOutputConfig]
- :param params: Additional domain-specific parameters for the predictions,
any string must be up to
+ :param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
Review comment:
```suggestion
:param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
```
This line is too long
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -300,7 +300,7 @@ def __init__( # pylint: disable=too-many-arguments
self.model_id = model_id
self.location = location
self.project_id = project_id
- self.params = params # type: ignore
+ self.prediction_params = prediction_params # type: ignore
Review comment:
```suggestion
self.prediction_params = prediction_params
```
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -240,9 +240,9 @@ class AutoMLBatchPredictOperator(BaseOperator):
written. If a dict is provided, it must be of the same form as the
protobuf message
`google.cloud.automl_v1beta1.types.BatchPredictOutputConfig`
:type output_config: Union[dict,
~google.cloud.automl_v1beta1.types.BatchPredictOutputConfig]
- :param params: Additional domain-specific parameters for the predictions,
any string must be up to
+ :param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
Review comment:
```suggestion
:param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
```
This line is too long
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -300,7 +300,7 @@ def __init__( # pylint: disable=too-many-arguments
self.model_id = model_id
self.location = location
self.project_id = project_id
- self.params = params # type: ignore
+ self.prediction_params = prediction_params # type: ignore
Review comment:
```suggestion
self.prediction_params = prediction_params
```
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -240,9 +240,9 @@ class AutoMLBatchPredictOperator(BaseOperator):
written. If a dict is provided, it must be of the same form as the
protobuf message
`google.cloud.automl_v1beta1.types.BatchPredictOutputConfig`
:type output_config: Union[dict,
~google.cloud.automl_v1beta1.types.BatchPredictOutputConfig]
- :param params: Additional domain-specific parameters for the predictions,
any string must be up to
+ :param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
Review comment:
```suggestion
:param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
```
This line is too long
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -300,7 +300,7 @@ def __init__( # pylint: disable=too-many-arguments
self.model_id = model_id
self.location = location
self.project_id = project_id
- self.params = params # type: ignore
+ self.prediction_params = prediction_params # type: ignore
Review comment:
```suggestion
self.prediction_params = prediction_params
```
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -240,9 +240,9 @@ class AutoMLBatchPredictOperator(BaseOperator):
written. If a dict is provided, it must be of the same form as the
protobuf message
`google.cloud.automl_v1beta1.types.BatchPredictOutputConfig`
:type output_config: Union[dict,
~google.cloud.automl_v1beta1.types.BatchPredictOutputConfig]
- :param params: Additional domain-specific parameters for the predictions,
any string must be up to
+ :param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
Review comment:
```suggestion
:param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
```
This line is too long
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -300,7 +300,7 @@ def __init__( # pylint: disable=too-many-arguments
self.model_id = model_id
self.location = location
self.project_id = project_id
- self.params = params # type: ignore
+ self.prediction_params = prediction_params # type: ignore
Review comment:
```suggestion
self.prediction_params = prediction_params
```
##########
File path: airflow/providers/google/cloud/operators/automl.py
##########
@@ -240,9 +240,9 @@ class AutoMLBatchPredictOperator(BaseOperator):
written. If a dict is provided, it must be of the same form as the
protobuf message
`google.cloud.automl_v1beta1.types.BatchPredictOutputConfig`
:type output_config: Union[dict,
~google.cloud.automl_v1beta1.types.BatchPredictOutputConfig]
- :param params: Additional domain-specific parameters for the predictions,
any string must be up to
+ :param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
Review comment:
```suggestion
:param prediction_params: Additional domain-specific parameters for the
predictions, any string must be up to
```
This line is too long
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
