Chris Riccomini commented on AIRFLOW-141:

Sounds good to me. One nit would be to rename the script to {{airflow-pr}} 
then, since some activities aren't about merging.

> Improve GitHub PR workflow Part 2 -- add options for working locally with PR
> ----------------------------------------------------------------------------
>                 Key: AIRFLOW-141
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-141
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Jeremiah Lowin
>            Assignee: Jeremiah Lowin
>            Priority: Minor
>             Fix For: Airflow 1.8
> The merge script proposed in AIRFLOW-134 is a one-stop shop for all PR 
> activities: it clones the PR locally, merges it, pushes to master, closes 
> JIRA issues, and allows users to supply notes/messages if appropriate. It 
> would be good to introduce an alternative workflow just for cloning PRs 
> locally. This can currently be done by starting the merge process and simply 
> not answering the question about pushing to master -- just letting the system 
> sit while the PR is explored. However, if a PR is not 100% ready to go we 
> don't want people one keystroke away from pushing it.
> The idea would be that the script would have different commands:
> {{airflow-merge-pr merge 100 # merge a PR}}
> {{airflow-merge-pr clone 100 # clone a PR locally for testing}}
> {{airflow-merge-pr cleanup # clean up after cloning}}
> etc.

This message was sent by Atlassian JIRA

Reply via email to