[ 
https://issues.apache.org/jira/browse/AIRFLOW-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684795#comment-15684795
 ] 

ASF subversion and git services commented on AIRFLOW-643:
---------------------------------------------------------

Commit 935ede22a2d447a9ef5cc03149d5306e13bd951f in incubator-airflow's branch 
refs/heads/master from [~Jalepeno112]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=935ede2 ]

[AIRFLOW-643] Improve date handling for sf_hook

Closes #1898 from Jalepeno112/feature/salesforce-
hook-coerce


> Improve coerce_to_timestamp for salesforce_hook
> -----------------------------------------------
>
>                 Key: AIRFLOW-643
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-643
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Giovanni Briggs
>            Assignee: Giovanni Briggs
>            Priority: Minor
>
> The salesforce_hook I created allows the user to chose to coerce all date and 
> datetime strings into Unix timestamps.  However, the current way this is 
> implemented will cause any string that even remotely resembles a date or 
> datetime to be converted.  For example, I just found a field in Salesforce 
> that is used to record the quarter in which an event occurred such as "2016 
> 02."  The hook will currently interpret this to mean "2016-02-01" and create 
> a Unix timestamp accordingly which is not accurate.
> I've changed the hook to only coerce fields that are of type "date" or 
> "datetime" in Salesforce.  All other strings are left alone which is much 
> more inline with the original intention of the feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to