Repository: incubator-airflow Updated Branches: refs/heads/master a3927e239 -> 5933fca1c
[AIRFLOW-771] Make S3 logs append instead of clobber Closes #2003 from aoen/ddavydov/make_airflow_logs_append_only Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/5933fca1 Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/5933fca1 Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/5933fca1 Branch: refs/heads/master Commit: 5933fca1cc3fef3248a44004f233f6213395811e Parents: a3927e2 Author: Dan Davydov <[email protected]> Authored: Fri Jan 20 16:40:20 2017 +0100 Committer: Bolke de Bruin <[email protected]> Committed: Fri Jan 20 16:40:28 2017 +0100 ---------------------------------------------------------------------- airflow/bin/cli.py | 5 +---- airflow/utils/logging.py | 4 ++-- 2 files changed, 3 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/5933fca1/airflow/bin/cli.py ---------------------------------------------------------------------- diff --git a/airflow/bin/cli.py b/airflow/bin/cli.py index 736df0a..46b7934 100755 --- a/airflow/bin/cli.py +++ b/airflow/bin/cli.py @@ -494,10 +494,7 @@ def run(args, dag=None): logging_utils.S3Log().write(log, remote_log_location) # GCS elif remote_base.startswith('gs:/'): - logging_utils.GCSLog().write( - log, - remote_log_location, - append=True) + logging_utils.GCSLog().write(log, remote_log_location) # Other elif remote_base and remote_base != 'None': logging.error( http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/5933fca1/airflow/utils/logging.py ---------------------------------------------------------------------- diff --git a/airflow/utils/logging.py b/airflow/utils/logging.py index 4a18476..96767cb 100644 --- a/airflow/utils/logging.py +++ b/airflow/utils/logging.py @@ -81,7 +81,7 @@ class S3Log(object): logging.error(err) return err if return_error else '' - def write(self, log, remote_log_location, append=False): + def write(self, log, remote_log_location, append=True): """ Writes the log to the remote_log_location. Fails silently if no hook was created. @@ -159,7 +159,7 @@ class GCSLog(object): logging.error(err) return err if return_error else '' - def write(self, log, remote_log_location, append=False): + def write(self, log, remote_log_location, append=True): """ Writes the log to the remote_log_location. Fails silently if no hook was created.
