[ 
https://issues.apache.org/jira/browse/AIRFLOW-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905504#comment-15905504
 ] 

Daniel Gies commented on AIRFLOW-965:
-------------------------------------


[~dxhuang] [~alexvanboxel] [~bolke] I believe with this change the ONE_SUCCESS 
is acting more like a ONE_DONE rule, or am I misunderstanding how it's supposed 
to work?

> ONE_SUCCESS TriggerRule is triggering with only skips
> -----------------------------------------------------
>
>                 Key: AIRFLOW-965
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-965
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: cli, DagRun, webserver
>    Affects Versions: Airflow 1.8
>         Environment: docker-compose using docker-compose-LocalExecutor.yml  
> on this fork/branch 
> https://github.com/fdm1/docker-airflow/tree/v1-8-not-skipping
>            Reporter: Daniel Gies
>             Fix For: 1.8.0rc5
>
>
> This commit 
> https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=commitdiff;h=1fdcf24
> Is causing Tasks with the ONE_SUCCESS trigger rule to trigger if any of their 
> upstream dependencies are skipped.
> This changes the previous behavior where ONE_SUCCESS would only fire if there 
> was, you know, a success.
> It is no longer possible to use ONE_SUCCESS as a wait() like mechanism to 
> collect branches of the DAG.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to