[
https://issues.apache.org/jira/browse/AIRFLOW-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zachary Lawson updated AIRFLOW-988:
-----------------------------------
Description: There is an issue in the current v1-8-stable branch. Looking
at the jobs.py module, if the system does not have email set up but does have a
sla_miss_callback defined in the DAG, that sla_miss_callback is repeated for
that job infinitely as long as the airflow scheduler is running. The offending
code seems to be in the query to the airflow meta database which filters to
sla_miss records that have *either* email_sent or notification_sent as false
([see lines
606-613|https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/jobs.py#L606-L613]),
but then executes the sla_miss_callback function regardless if
notification_sent was true ([see lines
644-648|https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/jobs.py#L644-L648]).
A conditional statement should be put prior to executing the sla_miss_callback
to check whether a notification has been sent to prevent this. (was: There is
an issue in the current v1-8-stable branch. Looking at the jobs.py module, if
the system does not have email set up but does have a sla_miss_callback defined
in the DAG, that sla_miss_callback is repeated for that job infinitely as long
as the airflow scheduler is running. The offending code seems to be in the
query to the airflow meta database which filters to sla_miss records that have
*either* email_sent or notification_sent as false ([see lines
606-613|https://github.com/apache/incubator-airflow/blob/bb39078a35cf2bceea58d7831d7a2028c8ef849f/airflow/jobs.py#L606-L613]),
but then executes the sla_miss_callback function regardless if
notification_sent was true ([see lines
644-648|https://github.com/apache/incubator-airflow/blob/bb39078a35cf2bceea58d7831d7a2028c8ef849f/airflow/jobs.py#L644-L648]).
A conditional statement should be put prior to executing the sla_miss_callback
to check whether a notification has been sent to prevent this.)
> SLA Misses Are Repeated if Email is Not being Used
> --------------------------------------------------
>
> Key: AIRFLOW-988
> URL: https://issues.apache.org/jira/browse/AIRFLOW-988
> Project: Apache Airflow
> Issue Type: Bug
> Affects Versions: Airflow 1.8
> Reporter: Zachary Lawson
>
> There is an issue in the current v1-8-stable branch. Looking at the jobs.py
> module, if the system does not have email set up but does have a
> sla_miss_callback defined in the DAG, that sla_miss_callback is repeated for
> that job infinitely as long as the airflow scheduler is running. The
> offending code seems to be in the query to the airflow meta database which
> filters to sla_miss records that have *either* email_sent or
> notification_sent as false ([see lines
> 606-613|https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/jobs.py#L606-L613]),
> but then executes the sla_miss_callback function regardless if
> notification_sent was true ([see lines
> 644-648|https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/jobs.py#L644-L648]).
> A conditional statement should be put prior to executing the
> sla_miss_callback to check whether a notification has been sent to prevent
> this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
