[ 
https://issues.apache.org/jira/browse/AIRFLOW-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929162#comment-15929162
 ] 

ASF subversion and git services commented on AIRFLOW-990:
---------------------------------------------------------

Commit 6bbf54154316ce4a7375d56c1e8922135b863ae7 in incubator-airflow's branch 
refs/heads/master from [~vitorbaptista]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=6bbf541 ]

[AIRFLOW-990] Fix Py27 unicode logging in DockerOperator

If a Docker container's logs has unicode values
(e.g. "echo 😁"), the
DockerOperator will try to log it using
`logging.info(line)`, which raises a
`UnicodeDecodeError`. To solve this, we need to
decode the string as UTF-8
before sending it to `logging.info()`.

Closes #2155 from vitorbaptista/bug/fixes-
AIRFLOW-990


> DockerOperator fails when logging unicode string
> ------------------------------------------------
>
>                 Key: AIRFLOW-990
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-990
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: docker
>    Affects Versions: Airflow 1.7.1
>         Environment: Python 2.7
>            Reporter: Vitor Baptista
>            Assignee: Vitor Baptista
>             Fix For: 1.9.0
>
>
> On line 
> https://github.com/apache/incubator-airflow/blob/1.7.1.3/airflow/operators/docker_operator.py#L164,
>  we're calling:
> {code:title=airflow/operators/docker_operator.py}
> for line in self.cli.logs(container=self.container['Id'], stream=True):
>     logging.info("{}".format(line.strip()))
> {code}
> If `self.cli.logs()` return a string with a unicode character, this raises 
> the UnicodeDecodeError:
> {noformat}
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/logging/__init__.py", line 861, in emit
>     msg = self.format(record)
>   File "/usr/lib/python2.7/logging/__init__.py", line 734, in format
>     return fmt.format(record)
>   File "/usr/lib/python2.7/logging/__init__.py", line 476, in format
>     raise e
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xf0 in position 0: 
> ordinal not in range(128)
> Logged from file docker_operator.py, line 165
> {noformat}
> A possible fix is to change that line to:
> {code:title=airflow/operators/docker_operator.py}
> for line in self.cli.logs(container=self.container['Id'], stream=True):
>     logging.info(line.decode('utf-8').strip())
> {code}.
> This error doesn't happen on Python3. I haven't tested, but reading the code 
> it seems the same error exists on `master` as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to