[
https://issues.apache.org/jira/browse/AIRFLOW-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Ishikawa updated AIRFLOW-1323:
---------------------------------
Description:
The parameters of {{DataprocClusterDeleteOperator}} and
{{DataprocClusterCreateOperator}} for GCP connection ID are
{{google_cloud_conn_id}}. On the other hand, for example,
{{DataProcPigOperator}}'s paramter is {{gcp_conn_id}}. I think this
inconsistency may make users confused. We should keep the parameter's name
consistent.
For another example, parameters for a cluster name don't have consistency like
{{cluster_name}} and {{dataproc_cluster}}.
-
https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L58
-
https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L626
was:
The parameters of {{DataprocClusterDeleteOperator}} and
{{DataprocClusterCreateOperator}} for GCP connection ID are
{{google_cloud_conn_id}}. On the other hand, for example,
{{DataProcPigOperator}}'s paramter is {{gcp_conn_id}}. I think this
inconsistency may make users confused. We should keep the parameter's name
consistent.
-
https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L58
-
https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L626
> Operators related to Dataproc should keep some parameters consistent
> --------------------------------------------------------------------
>
> Key: AIRFLOW-1323
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1323
> Project: Apache Airflow
> Issue Type: Improvement
> Components: operators
> Reporter: Yu Ishikawa
> Priority: Minor
>
> The parameters of {{DataprocClusterDeleteOperator}} and
> {{DataprocClusterCreateOperator}} for GCP connection ID are
> {{google_cloud_conn_id}}. On the other hand, for example,
> {{DataProcPigOperator}}'s paramter is {{gcp_conn_id}}. I think this
> inconsistency may make users confused. We should keep the parameter's name
> consistent.
> For another example, parameters for a cluster name don't have consistency
> like {{cluster_name}} and {{dataproc_cluster}}.
> -
> https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L58
> -
> https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L626
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
