[
https://issues.apache.org/jira/browse/AIRFLOW-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057990#comment-16057990
]
Chris Riccomini commented on AIRFLOW-1330:
------------------------------------------
I agree (2) is the right way to go.
I think the main thing to consider here is backwards compatibility. Can this
change be made in a non-hacky way without impacting existing CLI users? I'm not
100% opposed to backwards incompatible CLI param changes for the 1.9.0 release,
but we'd have to get broad support and communicate appropriately. It'd be a lot
easier if the command could be updated in a way that doesn't affect users that
are happy with the existing behavior.
> Connection.parse_from_uri doesn't work for google_cloud_platform and so on
> --------------------------------------------------------------------------
>
> Key: AIRFLOW-1330
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1330
> Project: Apache Airflow
> Issue Type: Bug
> Components: cli
> Reporter: Yu Ishikawa
>
> h2. Overview
> {{Connection.parse_from_uri}} doesn't work for some types like
> {{google_cloud_platform}} whose type name includes under scores. Since
> `urllib.parse.urlparse()` which is used in {{Connection.parse_from_url}}
> doesn't support a schema name which include under scores.
> So, airflow's CLI doesn't work when a given connection URI includes under
> scores like {{google_cloud_platform://XXXXX}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
