[ 
https://issues.apache.org/jira/browse/AIRFLOW-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126607#comment-16126607
 ] 

Ace Haidrey commented on AIRFLOW-1508:
--------------------------------------

After some looking into, I checked the usages of the {{State.task_states}} and 
it's only used here: 
https://github.com/apache/incubator-airflow/blob/master/airflow/www/views.py#L560.
 This just for task stats, so it won't affect anything else in the code base 
and just add another metric for skipped. I'll create a PR, but please let me 
know if this was intentionally left out.

> Skipped state not part of State.task_states
> -------------------------------------------
>
>                 Key: AIRFLOW-1508
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1508
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Ace Haidrey
>            Assignee: Ace Haidrey
>
> In the airflow.state module, 
> [State.task_state|https://github.com/apache/incubator-airflow/blob/master/airflow/utils/state.py#L44]
>  doesn't include the {{SKIPPED}} state even though the {{TaskInstance}} 
> object has it. I was wondering if this was on purpose or a bug. I would think 
> it should be part of the task_state object since that makes sense and will 
> help some of my workflows to not have to add this in manually. 
> I'm not sure who the appropriate person to ask is so thinking I'll tag some 
> people and get some feedback (hopefully that's okay)..
> CC [~criccomini] [~bolke]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to