[
https://issues.apache.org/jira/browse/AIRFLOW-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219459#comment-16219459
]
Colin Son commented on AIRFLOW-1756:
------------------------------------
[~ashb]
And another issue that I wanted to point out is that the unit tests for the
S3TaskHandler are broken. You can find them in here:
incubator-airflow/tests/utils/log/test_logging.py
This particular test is not part of a python package, so the tests don't run.
And the tests fail because S3TaskHandler object is not initialized correctly
(since it needs the correct args for the __init__). And the method names that
it is trying to test are all spelled incorrectly. So the unit tests should be
revisited as well.
Thanks!
> S3 Task Handler Cannot Read Logs With New S3Hook
> ------------------------------------------------
>
> Key: AIRFLOW-1756
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1756
> Project: Apache Airflow
> Issue Type: Bug
> Affects Versions: 1.9.0
> Reporter: Colin Son
> Fix For: 1.9.0
>
>
> With the changes to the S3Hook, it seems like it cannot read the S3 task logs.
> In the `s3_read` in the S3TaskHandler.py:
> {code}
> s3_key = self.hook.get_key(remote_log_location)
> if s3_key:
> return s3_key.get_contents_as_string().decode()
> {code}
> Since the s3_key object is now a dict, you cannot call
> `get_contents_as_string()` on a dict object. You have to use the S3Hook's
> `read_key()` method to read the contents of the task logs now.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
