[ 
https://issues.apache.org/jira/browse/AIRFLOW-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448446#comment-16448446
 ] 

ASF subversion and git services commented on AIRFLOW-2234:
----------------------------------------------------------

Commit 65b6ceae74c166efe95113ad5aa55004e2ad25c5 in incubator-airflow's branch 
refs/heads/master from [~sekikn]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=65b6cea ]

[AIRFLOW-2234] Enable insert_rows for PrestoHook

PrestoHook.insert_rows() raises
NotImplementedError for now.
But Presto 0.126+ allows specifying column names
in INSERT queries,
so we can leverage DbApiHook.insert_rows() almost
as is.
This PR enables this function.

Closes #3146 from sekikn/AIRFLOW-2234


> Enable insert_rows for PrestoHook
> ---------------------------------
>
>                 Key: AIRFLOW-2234
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2234
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>            Priority: Major
>             Fix For: 1.10.0
>
>
> PrestoHook.insert_rows() raises NotImplementedError for now.
> But [Presto 0.126+ allows specifying column names in INSERT 
> queries|https://prestodb.io/docs/current/release/release-0.126.html], so we 
> can leverage DbApiHook.insert_rows() almost as is.
> I think there is no reason to keep it disabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to