Repository: incubator-airflow
Updated Branches:
  refs/heads/master 06aec8ea6 -> 6ccce3ea0


[AIRFLOW-2486] Remove unnecessary slash after port

`self.base_url` includes an unnecessary slash when
`conn.port` is specified.
This often leads to unintended redirects that are
especially problematic when a request body is
needed.

Closes #3379 from jason-udacity/AIRFLOW-2486


Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/6ccce3ea
Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/6ccce3ea
Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/6ccce3ea

Branch: refs/heads/master
Commit: 6ccce3ea0e16ab57eab2499e7faf586004e8c3b2
Parents: 06aec8e
Author: Jason Shao <[email protected]>
Authored: Sat May 19 00:33:46 2018 +0200
Committer: Fokko Driesprong <[email protected]>
Committed: Sat May 19 00:33:46 2018 +0200

----------------------------------------------------------------------
 airflow/hooks/http_hook.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/6ccce3ea/airflow/hooks/http_hook.py
----------------------------------------------------------------------
diff --git a/airflow/hooks/http_hook.py b/airflow/hooks/http_hook.py
index a108b53..c449fe0 100644
--- a/airflow/hooks/http_hook.py
+++ b/airflow/hooks/http_hook.py
@@ -66,7 +66,7 @@ class HttpHook(BaseHook):
             self.base_url = schema + "://" + conn.host
 
         if conn.port:
-            self.base_url = self.base_url + ":" + str(conn.port) + "/"
+            self.base_url = self.base_url + ":" + str(conn.port)
         if conn.login:
             session.auth = (conn.login, conn.password)
         if conn.extra:

Reply via email to