[
https://issues.apache.org/jira/browse/AIRFLOW-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508529#comment-16508529
]
ASF subversion and git services commented on AIRFLOW-2581:
----------------------------------------------------------
Commit cae918e912fedd7d187a7ca9a9488e86caf6ad82 in incubator-airflow's branch
refs/heads/master from roc
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=cae918e ]
[AIRFLOW-2591][AIRFLOW-2581] Set default value of autocommit to False in
DbApiHook.run()
In previous PR (AIRFLOW-2581), I changed the
default value of
autocommit to True in DbApiHook.run(), which may
cause some performance
issues, so I changed it back to False.
Closes #3487 from imroc/AIRFLOW-2591
> Fix DbApiHook autocommit
> ------------------------
>
> Key: AIRFLOW-2581
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2581
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: 2.0.0, 1.10
> Reporter: roc chan
> Assignee: roc chan
> Priority: Major
> Fix For: 2.0.0
>
>
> *DbApiHook.run* actually do not commit when I set to *autocommit=True*
> for example: *hook.run(sql,autocommit=True)*
> this bug was introduced from
> [here|https://github.com/apache/incubator-airflow/pull/3257/commits/3450f526cec894cc7beceeae18f9d54cb2ae7520]
> , and there is a fix
> [here|https://github.com/apache/incubator-airflow/pull/3258/commits/bf244701e35e973c6b7ee2ee41e5524ceafeed30]
> , which didn't fix it at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
