[ 
https://issues.apache.org/jira/browse/AIRFLOW-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Trevor Edwards updated AIRFLOW-2786:
------------------------------------
    Description: 
Reported 
[here|[https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/cloud-composer-discuss/OkYMeuwqOpU]]
 if a Variable has an empty key, the Variables tab is not accessible.

Part of the relevant stacktrace:

 
{code:java}
  File "/usr/local/lib/python2.7/site-packages/flask_admin/model/base.py", line 
1742, in get_list_value
    self.column_type_formatters,
  File "/usr/local/lib/python2.7/site-packages/flask_admin/model/base.py", line 
1707, in _get_list_value
    value = column_fmt(self, context, model, name)
  File "/usr/local/lib/python2.7/site-packages/airflow/www/views.py", line 
2269, in hidden_field_formatter
    if wwwutils.should_hide_value_for_key(model.key):
  File "/usr/local/lib/python2.7/site-packages/airflow/www/utils.py", line 49, 
in should_hide_value_for_key
    return any(s in key_name.lower() for s in 
DEFAULT_SENSITIVE_VARIABLE_FIELDS) \
  File "/usr/local/lib/python2.7/site-packages/airflow/www/utils.py", line 49, 
in <genexpr>
    return any(s in key_name.lower() for s in 
DEFAULT_SENSITIVE_VARIABLE_FIELDS) \
AttributeError: 'NoneType' object has no attribute 'lower'
{code}

  was:
Reported 
[here|[https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/cloud-composer-discuss/OkYMeuwqOpU],]
 if a Variable has an empty key, the Variables tab is not accessible.

Part of the relevant stacktrace:

 
{code:java}
  File "/usr/local/lib/python2.7/site-packages/flask_admin/model/base.py", line 
1742, in get_list_value
    self.column_type_formatters,
  File "/usr/local/lib/python2.7/site-packages/flask_admin/model/base.py", line 
1707, in _get_list_value
    value = column_fmt(self, context, model, name)
  File "/usr/local/lib/python2.7/site-packages/airflow/www/views.py", line 
2269, in hidden_field_formatter
    if wwwutils.should_hide_value_for_key(model.key):
  File "/usr/local/lib/python2.7/site-packages/airflow/www/utils.py", line 49, 
in should_hide_value_for_key
    return any(s in key_name.lower() for s in 
DEFAULT_SENSITIVE_VARIABLE_FIELDS) \
  File "/usr/local/lib/python2.7/site-packages/airflow/www/utils.py", line 49, 
in <genexpr>
    return any(s in key_name.lower() for s in 
DEFAULT_SENSITIVE_VARIABLE_FIELDS) \
AttributeError: 'NoneType' object has no attribute 'lower'
{code}


> Variables view fails to render if a variable has an empty key
> -------------------------------------------------------------
>
>                 Key: AIRFLOW-2786
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2786
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Trevor Edwards
>            Priority: Minor
>
> Reported 
> [here|[https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/cloud-composer-discuss/OkYMeuwqOpU]]
>  if a Variable has an empty key, the Variables tab is not accessible.
> Part of the relevant stacktrace:
>  
> {code:java}
>   File "/usr/local/lib/python2.7/site-packages/flask_admin/model/base.py", 
> line 1742, in get_list_value
>     self.column_type_formatters,
>   File "/usr/local/lib/python2.7/site-packages/flask_admin/model/base.py", 
> line 1707, in _get_list_value
>     value = column_fmt(self, context, model, name)
>   File "/usr/local/lib/python2.7/site-packages/airflow/www/views.py", line 
> 2269, in hidden_field_formatter
>     if wwwutils.should_hide_value_for_key(model.key):
>   File "/usr/local/lib/python2.7/site-packages/airflow/www/utils.py", line 
> 49, in should_hide_value_for_key
>     return any(s in key_name.lower() for s in 
> DEFAULT_SENSITIVE_VARIABLE_FIELDS) \
>   File "/usr/local/lib/python2.7/site-packages/airflow/www/utils.py", line 
> 49, in <genexpr>
>     return any(s in key_name.lower() for s in 
> DEFAULT_SENSITIVE_VARIABLE_FIELDS) \
> AttributeError: 'NoneType' object has no attribute 'lower'
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to